Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add var port polling in host phase to flush out any pending reads #563

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Add var port polling in host phase to flush out any pending reads #563

merged 2 commits into from
Jan 9, 2023

Conversation

joyeshmishra
Copy link
Contributor

Issue Number:

Objective of pull request:

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@joyeshmishra joyeshmishra requested a review from ysingh7 January 5, 2023 22:50
@joyeshmishra joyeshmishra mentioned this pull request Jan 5, 2023
Closed
1 task
@joyeshmishra joyeshmishra linked an issue Jan 5, 2023 that may be closed by this pull request
Non-deterministic behavior when writing from RefPorts #370
Closed
1 task
@mathisrichter
Copy link
Contributor

mathisrichter commented Jan 9, 2023 •
edited
Loading

@joyeshmishra Is there another unit test in Lava that already covers this bug? If not, please consider adding the unit test I attached in the linked issue to this PR.
Or, maybe it is sufficient to have the unit tests for virtual ports cover this? I am concerned that we do not have dedicated unit tests for RefPorts (and other ports?) that would have shown this bug isolated from virtual ports.

@joyeshmishra
Copy link
Contributor Author

Sure, let me add that unit test

@joyeshmishra joyeshmishra merged commit 1f40e08 into main Jan 9, 2023
@joyeshmishra joyeshmishra deleted the var_port_ref_port_randomness branch January 9, 2023 19:35
monkin77 pushed a commit to monkin77/thesis-lava that referenced this pull request Jul 12, 2024
@joyeshmishra
Add var port polling in host phase to flush out any pending reads (la…
d3e9774 
…va-nc#563)

* Add var port polling in host phase to flush out any pending reads

* Added unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippPlank PhilippPlank PhilippPlank approved these changes

@ysingh7 ysingh7 ysingh7 approved these changes

@harryliu-intel harryliu-intel Awaiting requested review from harryliu-intel

@mathisrichter mathisrichter Awaiting requested review from mathisrichter

@mgkwill mgkwill Awaiting requested review from mgkwill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-deterministic behavior when writing from RefPorts
4 participants
@joyeshmishra @mathisrichter @ysingh7 @PhilippPlank